search

nickjj / ansible-nginx

Install and configure nginx (SSL A+ by default) with Ansible.
MIT License
73 stars 37 forks source link

Remove nginx_ssl_override_filename from defaults avoiding wrong certificate names #11

Closed speedmann closed 6 years ago

speedmann commented 7 years ago

This fixes #10

speedmann commented 7 years ago

I am doing this the first time, so I hope I did everything correct

nickjj commented 7 years ago

Hi, thanks.

What you did technically works, but you should also update the README.md file too.

Something like this should work:

# If defined, override the default value for SSL certificate names. If you
# leave this undefined, then it will become the file name of the first domain listed
# in the domains list when defining a virtual host (look in the next section).
#
# Setting this comes in handy if you use Let's Encrypt and want to register a
# single certificate that has multiple domains attached to it.
# nginx_ssl_override_filename: 'customcertname'
speedmann commented 6 years ago

hi there, does anything need more fixes to be able to be merged?

cristoper commented 6 years ago

It would be nice if this were merged. As a workaround until then, I'm setting the variable explicitly in my playbook like:

nginx_ssl_override_filename: "{{ letsencrypt_domains[0] }}"