Fix "no filter named 'changed'" and nginx restart

nickjj / ansible-nginx

Install and configure nginx (SSL A+ by default) with Ansible.

MIT License

73 stars 37 forks source link

Fix "no filter named 'changed'" and nginx restart #23

Closed n00b42 closed 2 years ago

n00b42 commented 2 years ago

Replaced | changed with is changed. (Fixes #22)

Furthermore, if I am not mistaken nginx should be restarted if either config changes, not only if both change, correct?

nickjj commented 2 years ago

Thanks for the submission and catch on the or vs and.

A dirty secret is I have a different nginx role that has been written from the ground up, it's not open source yet but I wanted to drop that in to mention I haven't used this specific role in like 5 years. When the new one is available I'll archive this one.

n00b42 commented 2 years ago

Thanks for merging.

Yeah, I read in some issue messages from 2018/2022 that you are rewriting stuff, and I already feared that given that long time, the project might be dead, but I am happily proven wrong ;)

nickjj commented 2 years ago

It's still happening, it's just I haven't figured out how to make courses yet full time so I still spend a huge majority of my time doing "regular" work. Eventually everything will be released, pulling together everything I've learned around deploying web apps and while the videos won't be free, the Ansible code will all be open source.