Fixes the breaking change in webpacker

nickjj / docker-rails-example

A production ready example Rails app that's using Docker and Docker Compose.

MIT License

941 stars 185 forks source link

Fixes the breaking change in webpacker #18

Closed fiveNinePlusR closed 3 years ago

fiveNinePlusR commented 3 years ago

The chunking by default option in webpacker now breaks if the javascript_pack_tag is used.

closes #17

nickjj commented 3 years ago

Hi,

Thanks so much for the fix. I can confirm it's working here.

Can you please force push a new commit message of this and then I'll merge it:

Fix JavaScript not loading with Webpacker 6

The chunking by default option in Webpacker 6 breaks if
javascript_pack_tag is used.

Prior to this patch the JS would load but it wouldn't execute.

nickjj commented 3 years ago

On second thought, a new fix came about where everything makes sense based on following a few PRs on Webpacker. I replied in the linked issue with more details https://github.com/nickjj/docker-rails-example/issues/17#issuecomment-872128627.

I appreciate you looking into this! It lead to a working solution in any case. Now we can continue using the regular javascript_pack_tag.