nickjj / docker-rails-example

A production ready example Rails app that's using Docker and Docker Compose.
MIT License
975 stars 197 forks source link

Update Node and Yarn install strategy #67

Closed travisdock closed 1 year ago

travisdock commented 1 year ago

I'm back with more Node updates :)

I noticed this while working on my other PR.

Screenshot 2023-09-08 at 8 41 13 PM

Node makes you wait a whole 60 seconds as punishment for using a deprecated script.

From the nodesource github repo:

The installation scripts setup_XX.x are no longer supported and are not needed anymore, as the installation process is straightforward for any RPM and DEB distro.

I copied and pasted their installation instructions exactly.

From the yarn website:

The preferred way to manage Yarn is by-project and through Corepack, a tool shipped by default with Node.js. Modern releases of Yarn aren't meant to be installed globally, or from npm.

To enable Yarn apparently all you have to do is enable Corepack.

nickjj commented 1 year ago

Hi, thanks. I'm replying to acknowledge that I've seen the PR. I'll do a proper review within the next couple of days.