search

nickjj / docker-rails-example

A production ready example Rails app that's using Docker and Docker Compose.
MIT License
941 stars 185 forks source link

bugfix - image wont show when using local activestorage #77

Open mirzalazuardi opened 3 months ago

mirzalazuardi commented 3 months ago

Hi @nickjj,

I found the issue when i using activestorage with disk service, and got me errors when i check on the image url. The image also wont show on the web. But i already found a solution for this. which is to add some dependencies. Please check my PR

Thanks

nickjj commented 3 months ago

Hi,

Yep, ActiveStorage requires system level dependencies and libvips is the way to go. I've added that package to my own personal projects that use it.

The concern here is not everyone uses ActiveStorage and including libvips increases the Docker image size. If we wanted to make ActiveStorage work out of the box for this example project it would require also adding new JavaScript dependencies for direct upload support and modifying the app JS code to include it.

Maybe we can keep this PR open to see if others are interested in having ActiveStorage be included by default. If there's demand for that, I'd be happy to add it.

mirzalazuardi commented 3 months ago

Thanks... happy to help & contribute to your project