search

nickjj / docker-rails-example

A production ready example Rails app that's using Docker and Docker Compose.
MIT License
941 stars 185 forks source link

Remove all export statements #9

Closed baldrailers closed 3 years ago

baldrailers commented 3 years ago

Having export doesn't work with docker-compose

Screen Shot 2021-03-01 at 10 20 45 AM
nickjj commented 3 years ago

Hi,

What version of Docker Compose are you using?

I believe it was version 1.26 from June 2020 that added support for being able to use whitespace (and in turn export).

If you update to 1.26 or newer it'll work. If you remove export then you won't be able to source the .env file in the run script which becomes an issue because that's how we read in certain env variable values to avoid having to hard code secrets and other information.

baldrailers commented 3 years ago 
docker-compose version 1.25.0, build unknown
docker-py version: 4.1.0
CPython version: 3.8.5
OpenSSL version: OpenSSL 1.1.1f  31 Mar 2020