search

nickjj / manifest-revision-webpack-plugin

Write out a manifest file containing your versioned webpack chunks and assets.
ISC License
124 stars 40 forks source link

Add support to webpack 3 #38

Closed lucascarvalho closed 7 years ago

lucascarvalho commented 7 years ago

Feel free to review, merge and publish a new version.

fdanielsen commented 7 years ago

In reference to #27, this solves the issue in a way that has worked for us for a while now. Literally line by line this is my implementation as seen here, I guess great minds think alike ;)

I didn't have time to push my patch out as a PR during vacation etc., so feel free to get this merged and released. I have no idea why the CI fails though.

lucascarvalho commented 7 years ago

I tried to put everything together in one PR, including the package.json so other developers wouldn't have to search for the solution in all the forks. All the credits go to you @fdanielsen. :)

I've been using it since then and it works like a charm. Thank you. (:

nickjj commented 7 years ago

It seems to fail specifically on Node 0.10, but passes on 0.11 and 0.12.

Details of the failure can be found at: https://travis-ci.org/nickjj/manifest-revision-webpack-plugin/jobs/254974805.

And the 2 passing runs can be seen here: https://travis-ci.org/nickjj/manifest-revision-webpack-plugin/builds/254974802

lucascarvalho commented 7 years ago

Hi @nickjj, It seems to be working now. Let me know if you need something else. Thanks. (:

fdanielsen commented 7 years ago

Seems like a simple fix to keep node 0.10 support. But for the future, Webpack hasn't officially supported node 0.10 in a while, so it might not be too important to keep support that far back?

nickjj commented 7 years ago

Thanks guys. Looks good.

Sounds like the travis.yml file should also get updated to include more modern versions of Node.