search

nickjj / orats

Opinionated rails application templates.
MIT License
664 stars 56 forks source link

Bump Ruby version used by Rubocop to 2.5 #46

Closed Quintasan closed 6 years ago

Quintasan commented 6 years ago

Fix #45 failing in Travis CI

Quintasan commented 6 years ago

@nickjj This is optional but I think we could just bump it all the way up to 2.5

nickjj commented 6 years ago

I vaguely remember trying 2.5 but ran into a bunch of rubocop warnings. Have you tried running rubocop locally with that setting?

Quintasan commented 6 years ago

@nickjj 100% of those is Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

I think it's better to apply this style guide now but it's up to you.

EDIT: I pushed it up with the style guide as a separate commit in case you don't like it.

nickjj commented 6 years ago

I think we should remove the literal string spam on all of the files, that just feels messy to maintain.

I wonder if rubocop has a way to ignore that at the yml level. I don't think it did at the time I looked.

Quintasan commented 6 years ago

@nickjj There you go

nickjj commented 6 years ago

Thanks.