General changes to how daemons work

nickkeesG commented 4 months ago

ignore previous pull request, added one last commit to this one to fix a mistake

I've revamped the daemon prompt pipelines, and made them fully configurable in the settings (removing as many hard-coded elements as possible).

I've also added 4 new daemons which show how the new configs work (though I don't claim they are very good).

Some other things:

there are some extra options in the settings for configuring the instruct daemon and controlling the temperature of base model
instructions and instruct-daemon responses now appear differently in the UI to make clear that they are not a part of the context
daemons respond to their name being mentioned
left and right column are the same now, and daemon messages alternate from left to right
I added a help button, though the actual contents of the help are still a todo
I gave the surprisal metric an actual function: it is used now in the daemonManager to select which idea to respond to (user can still toggle whether this surprisal is overlayed on the text)

I may have forgotten something, sorry it's all a bit chaotic but I've done my best to clean it up. Please bother me if something looks concerning.

netlify[bot] commented 4 months ago

Deploy Preview for gleeful-biscuit-343233 ready!

Name	Link
Latest commit	e69170ba8aef058c63e563e50480f3bc71cb71cb
Latest deploy log	https://app.netlify.com/sites/gleeful-biscuit-343233/deploys/6618468c0310bf0008ad92bc
Deploy Preview	https://deploy-preview-63--gleeful-biscuit-343233.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 65 (🟢 up 1 from production) Accessibility: 95 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

sofvanh commented 4 months ago

I started by testing the version on Netlify. Looks pretty good.

Got crash / blank screen after writing some ideas before I put in an OpenAI key.
Info box is a great addition. Let's write something there, even something short. There's no need to publish an empty placeholder onto production
Lots of stuff in the browser console. Let's by default not print anything there. (We can add dev mode logging but shouldn't be printing logs to console in production.)
- This means we should remove the 'user active' and 'user inactive' notes from there as well.
Now that there's only one type of comments, I think we should modify the UI so that there's only one comment panel. What do you think? (I can work on this unless you have a strong intuition on how the new UI should look.)

(Next I'll read through the actual code and leave comments as I go.)

sofvanh commented 4 months ago

Btw I hope this review didn't feel demoralising! Overall this is great work for a first-time pull request :) I'm excited to get this merged, for the code improvements and the UX improvements as well!!

You asked how important it is to me to make the comments fit into one panel. I think it's probably a nice UI improvement, (and also would simplify the code a bit,) but I'd be happy to work on that after we've finished this. So don't worry about it for now.

nickkeesG / Pantheon