nicklan / pnmixer

Volume mixer for the system tray
GNU General Public License v3.0
152 stars 32 forks source link

Use GNotification instead of libnotify #103

Closed elboulangero closed 8 years ago

elboulangero commented 9 years ago

See this page: https://developer.gnome.org/GNotification

I'd like to give it a try when I have some time. Then we could drop the libnotify dependency, and there would be no need to make notifications optional since it's built-in in GLib.

hasufell commented 8 years ago

I've done that in a local branch. It doesn't look like a good idea to me, because there are several problems:

hasufell commented 8 years ago

https://github.com/hasufell/pnmixer/commit/b0982d44f7630b686ea870a59234f968986dc20a https://github.com/hasufell/pnmixer/tree/GNotification

elboulangero commented 8 years ago

I didn't have time to look at that yet. I think I will have time in a few weeks. Please keep your branch alive until then :smile:

elboulangero commented 8 years ago

Hey I had a quick look, indeed I agree with you.

At first I though that GNotification was roughly like "libnotify merged into GLib". But not really. It seems that it addresses different need.

One of the main advantages of GNotification is the persistence of notifications. But for PNMixer, we don't want that.

Also, when reading about it on GNotification HowdoI, I have a strange feeling. It looks like a "gnome-oriented" feature, which makes me wary.

So, yeah, let's stick with libnotify. It does the job.