search

nicklan / pnmixer

Volume mixer for the system tray
GNU General Public License v3.0
152 stars 32 forks source link

Popup orientation #117

Closed elboulangero closed 8 years ago

elboulangero commented 8 years ago

Match #116

All in all it was quite easy to implement

elboulangero commented 8 years ago

Tell me what you think, if you're OK we merge that

hasufell commented 8 years ago

I'm just wondering how useful this choice actually is. I'm not the minimalist GUI guy but customizing the whole layout shouldn't be priority. Next thing, someone wants a different slider knob ;)

elboulangero commented 8 years ago

Well, I don't totally agree with you. Sure it's not priority, but it's not useless either. Depending on one's desktop layout (ie horizontal or vertical panel), or one's personal taste, one may be happy to have this feature. And PNMixer is all about being featurefull, so it makes sense.

Customizing the layout is quite simple, since the popup window is really a simple thing (see 615068). The whole changeset is not big and doesn't add anything tricky.

And to finish, I must say that I've been thinking about that from the very beginning of the Gtk3 port, since I much preferred the horizontal layout. So it's true, this feature is for me, but I decided to implement it only after reading someone saying that he preferred the horizontal layout too, so it's not totally selfish. To me it makes PNMixer a little bit better.

hasufell commented 8 years ago

Sure, if you like to spend time on it.

elboulangero commented 8 years ago

Reworked and done in #118