Popup orientation 2 - Githubissues

elboulangero commented 8 years ago

Better implementation.

In a few words (read commit messages for more details):

in a first time, split popup ui file, since it contains two different popup completely unrelated: menu popup and volume popup.
now that volume popup has its own files (which is very short and simple), I just duplicate it and edit the layout. So there's one ui file for horizontal layout, one for vertical layout.

Compared to the former PR (#117), this implementation has the advantage to be more straight forward. It doesn't add little tricky and weird code, it's gonna be easier to read and understand how the two layouts are implemented. So, better in term of maintenance.

Also, it works with Gtk2 too.

elboulangero commented 8 years ago

I improved the two layouts feature, now the implementation looks better, less tricky. I'll merge that if nobody speaks against it :)

hasufell commented 8 years ago

where do the merge conflicts come from?

elboulangero commented 8 years ago

I've been touching the same files on master, just to make the merge a little bit more challenging ;)

elboulangero commented 8 years ago

Merged !

nicklan / pnmixer

Popup orientation 2 #118