Release 0.7

[elboulangero]

That's it, I'd be happy to release a new version with the new PNMixer code.

[hasufell]

I wonder if we should rather do 0.6.2... 0.7 gives a feeling of new features, while this is mainly code refactoring

[elboulangero]

And 0.6.2 gives me a feeling of bugs fixed, while this is probably... bugs created ;) I will review the changes that happened since 0.6 and sum that up in the Changelog so that we have a better view of what happened lately

[elboulangero]

Hi ! I updated the Changelog on my branch, to me there's quite a few change, making a new major version seems just like the logical thing to do. Have a look at the commit here: https://github.com/elboulangero/pnmixer/commit/674c4a8af01cf3768a6852577409ddbac7bb26a3

[hasufell]

a documentation warning:

/home/jule/git/pnmixer/src/audio.c:430: warning: argument 'volume' of command @param is not found in the argument list of _audio_set_volume(Audio *audio, AudioUser user, gdouble cur_volume, gdouble new_volume, gint dir)
/home/jule/git/pnmixer/src/audio.c:439: warning: The following parameters of _audio_set_volume(Audio *audio, AudioUser user, gdouble cur_volume, gdouble new_volume, gint dir) are not documented:
  parameter 'cur_volume'
  parameter 'new_volume'

relevant code:

/**
 * Set the volume.
 *
 * @param audio an Audio instance.
 * @param user the user who performs the action.
 * @param volume the volume value to set, in percent.
 * @param dir the direction for the volume change
 *        (-1: lowering, +1: raising, 0: setting).
 */
void
_audio_set_volume(Audio *audio, AudioUser user, gdouble cur_volume,
                  gdouble new_volume, gint dir)

[hasufell]

We should also add doxygen graphviz as dependencies for building the documentation to README.md.

[elboulangero]

Done

[hasufell]

I guess you can create the PR now. Is there anything that has changed for packagers except the tighter gtk+:3 version constraint?

[elboulangero]

I think there's only Gtk version, you're right.

[elboulangero]

PR created, waiting for Travis to do its job

[elboulangero]

Ok, I contacted the TP for translation, it's in progress. People out there, feel free to use and test PNMixer like crazy. When the translations will be done, we can make a release, no need to wait I think.

[elboulangero]

Btw, lately I changed my Gtk theme, and I noticed that a few things were broken in the UI, in the prefs dialog. It was not visible with my previous theme. So I fixed that. It would be good if other people could give it a quick look, just to be sure the UI looks OK with their theme.

[elboulangero]

Ok, I imported translations from the TP. Result: 4 new translations ! But none of the existing translations were updated...

Through Github though, we had Chinese and Russian translations updated.

So, we're left with 3 translations to update: French, German and Italian. I'll take care of the French. @hasufell, you want to do the German ? As for the Italian, well I guess we will just let it like that.

[hasufell]

you want to do the German ?

Maybe, but I have a change of job, so not sure if I can get to it in time.

[elboulangero]

Oh, I just received the German translation on the TP: http://translationproject.org/latest/pnmixer/de.po Lucky you !

[elboulangero]

Ok, almost ready to release, just waiting for #127 and #136

[elboulangero]

OK to release it seems to me

[hasufell]

what about #136 ?

[elboulangero]

I really think it's not a PNMixer bug, so I would just let it be. I mean, I'd let the ticket report open, and just remove it from the 0.7 milestone...

[elboulangero]

I cooked a little test that shows the bug, so definitely not a PNMixer bug to me.

git clone https://github.com/elboulangero/gtk-status-icon-size-test.git

[hasufell]

can we nail it down to a function? I mean which function behaves differently in terms of gtk2 vs gtk3?

[elboulangero]

I believe it's the code that resize the PNG and display it. It happens somewhere when we assign the PNG, through gtk_status_icon_set_from_file() in this example, or gtk_status_icon_set_from_pixbuf() in PNMixer.

[hasufell]

The icons (without the vol_meter) look different for gtk2 and gtk3, although they are from the same file: gtk2: gtk3:

There seems to be more space to the left for the gtk2 icon.

[elboulangero]

Yep the Gtk3 icon seems to be a bit bigger...

Anyway, do we release ?

[hasufell]

I'm doing some testing now and then we should release

[hasufell]

I think we are ready

[hasufell]

All that's left now should be to create the actual release on the release page.

Note: the release tag should be already existent and gpg signed. I have done that locally. Should I push the tag?