nicklan / pnmixer

Volume mixer for the system tray
GNU General Public License v3.0
152 stars 32 forks source link

Extraneous newline in notification summary #147

Closed bandali0 closed 8 years ago

bandali0 commented 8 years ago

Is the \n in the end of the notification summary intentional?

https://github.com/nicklan/pnmixer/blob/7a1b71c5ebeab6795c866ebb6e7bd88275a910a5/src/notif.c#L79

It makes the notifications look out of place in dunst.

elboulangero commented 8 years ago

Hi, I think it's a mistake. I actually never saw these lines. What I see with my setup is an icon and a volume slider.

pnmixer-0 7-noti

bandali0 commented 8 years ago

Hi @elboulangero,

That makes sense, since xfce4-notifyd shows a progress bar and no text summary.

This however is what I see with dunst:

pnmixer-notif

And this is a normal notification for reference (no extra \n in the end):

brightness-notif

elboulangero commented 8 years ago

Cool, thanks for the feedback and screenshots. Fixed by commit 5f6c1701355478df2e79c4716bfdb836c475d527.

bandali0 commented 8 years ago

Cheers :beers: