while packaging for Debian, a maintainer pointed out a little inconsistency in the tarballs.
If you look at the one we build manually [1], you will see that the base directory is pnmixer-v0.7.2. We use the tag to create the base directory.
If you look at the tarball generated by GitHub [2], you will see that the base directory is pnmixer-0.7.2. Somehow, GitHub picks up the version.
Additionally, when I build a package for Debian with git buildpackage, the tool generates an archive, and uses the version for the prefix, hence the base directory is pnmixer-0.7.2. Same as GitHub.
For the sake of consistency, I suggest that we also use the version instead of the tag for the base directory in the archive. Then the GitHub archive and our home-built archive will be identical, which is kind of expected, since both are built from the git source.
I made the change in the branch release-prefix-in-archive, commit ddd74e0c9ff45e8dfe96a23d962521ec0a0228dc. Can you please have a look and merge if you agree ?
Hey @hasufell,
while packaging for Debian, a maintainer pointed out a little inconsistency in the tarballs.
If you look at the one we build manually [1], you will see that the base directory is
pnmixer-v0.7.2. We use the tag to create the base directory.If you look at the tarball generated by GitHub [2], you will see that the base directory is
pnmixer-0.7.2. Somehow, GitHub picks up the version.Additionally, when I build a package for Debian with
git buildpackage, the tool generates an archive, and uses the version for the prefix, hence the base directory ispnmixer-0.7.2. Same as GitHub.For the sake of consistency, I suggest that we also use the version instead of the tag for the base directory in the archive. Then the GitHub archive and our home-built archive will be identical, which is kind of expected, since both are built from the git source.
I made the change in the branch
release-prefix-in-archive, commit ddd74e0c9ff45e8dfe96a23d962521ec0a0228dc. Can you please have a look and merge if you agree ?Cheers 1
[1] https://github.com/nicklan/pnmixer/releases/download/v0.7.2/pnmixer-v0.7.2.tar.gz [2] https://github.com/nicklan/pnmixer/archive/v0.7.2.tar.gz