nicklaw5 / helix

A Twitch Helix API client written in Go.
MIT License
240 stars 91 forks source link

Add Twitch Extension endpoints in Helix #114

Closed jackmcguire1 closed 2 years ago

jackmcguire1 commented 2 years ago

Twitch are deprecating the Extension endpoints and migrated them to helix

This work is based off of my go module go-twitch-ext and for simplicity I would like to migrate to Helix

FEATURES: JWT:

Endpoints:

Things to note:

TODO:

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1185154481


Changes Missing Coverage Covered Lines Changed/Added Lines %
extension_pubsub.go 33 35 94.29%
extensions.go 14 16 87.5%
extension_configuration.go 37 44 84.09%
helix.go 1 11 9.09%
extension_jwt.go 56 75 74.67%
extension_secrets.go 0 20 0.0%
<!-- Total: 141 201 70.15% -->
Totals Coverage Status
Change from base Build 1179954764: -4.09%
Covered Lines: 1205
Relevant Lines: 1302

💛 - Coveralls
nicklaw5 commented 2 years ago

@jackmcguire1 Is this ready to be reviewed? Or are you still making changes?

jackmcguire1 commented 2 years ago

@nicklaw5 maybe have a skim through if you have a chance and see what I’m trying to achieve.

it’s a still not complete, sorry I’ve had covid and bad food poisoning recently and not had the energy to pick this up.

jackmcguire1 commented 2 years ago

@nicklaw5 hi nick, i have squashed the commits and pushed some more tests, i believe this is in a state for review now

jackmcguire1 commented 2 years ago

pushed changes @nicklaw5

nicklaw5 commented 2 years ago

Appreciate you making those adjustments :+1: