Allow querying multiple channels at once in `GetChannelInformation`

nicklaw5 / helix

A Twitch Helix API client written in Go.

MIT License

243 stars 88 forks source link

Allow querying multiple channels at once in `GetChannelInformation` #117

Closed zneix closed 3 years ago

zneix commented 3 years ago

This is a breaking change and would need to be addressed in the release changelog.

Closes #116

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 1179947554

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.639%

Totals
Change from base Build 1175197420:	0.0%
Covered Lines:	1064
Relevant Lines:	1101

💛 - Coveralls

zneix commented 3 years ago

I'd prefer we not introduce this as a breaking change. Let's leave BroadcasterID as it is and introduce a new BroadcasterIDs field for handling this new use case.

Did exactly this, added 2 new test cases that are using multiple BroadcasterIDs (one that "passes" and one that "fails").