Correcting scopes to pass as space-separated list

nicklaw5 / helix

A Twitch Helix API client written in Go.

MIT License

243 stars 88 forks source link

Correcting scopes to pass as space-separated list #65

Closed intel352 closed 3 years ago

intel352 commented 3 years ago

Correcting scopes to pass as space-separated list, rather than &scope…=...&scope=..., per the documentation.

Without this change, the API only recognizes the first scope that is passed.

Existing tests are unaffected either way. The difference is that when scopes are actually being requested against a live twitch service, the scopes that are returned always only reflects the first one in the list.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 387881505

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.733%

Totals
Change from base Build 383850849:	0.0%
Covered Lines:	673
Relevant Lines:	750

💛 - Coveralls

nicklaw5 commented 3 years ago

I just realised I completely misunderstood the changes you've introduced. Please ignore my comments.

intel352 commented 3 years ago

I just realised I completely misunderstood the changes you've introduced. Please ignore my comments.

No worries, I actually debated even renaming the property to reduce confusion, as it's a bit misleading. Good thing IDEs tell us if it's wrong :)