search

nicklaw5 / helix

A Twitch Helix API client written in Go.
MIT License
240 stars 91 forks source link

Get Emote Sets missing OwnerID value #98

Closed pajlada closed 3 years ago

pajlada commented 3 years ago

The Get Emote Sets function is missing the OwnerID value returned from the API.

The simple solution is to add OwnerID to the Emote type, but that'd mean an empty value in the other calls using the type (i.e. Get Channel Emotes and Get Global Emotes). The complex solution is to return a different type in the response of Get Emote Sets.

I'm happy to make the change with a PR but I'd like to hear your preferred solution first.

Scorfly commented 3 years ago

Hello !

I missed this argument when i impleted those calls.

Personally, I would do 2 structs

nicklaw5 commented 3 years ago

I agree with @Scorfly, let's go with two different structs. A PR would be very much appreciated.