Redfish error report lib

nicklela / edk2-redfish-client-deprecated

Edk2 RedfishClientPkg workplace

Other

0 stars 0 forks source link

Redfish error report lib #23

Open nicklela opened 1 year ago

nicklela commented 1 year ago

Server usually has its own error logging mechanism. Although Redfish has error report definition. Do we consider to create a library so plat form can link to their own error logging system?

nicklela commented 1 year ago

We can use REPORT_STATUS_CODE_XXX() defined in edk2/MdePkg/Include/Library/ReportStatusCodeLib.h to return Redfish errors. When BMC follows ARM SBMR specification, these progress code can be logged in BMC.

nicklela commented 1 year ago

Possible solution:

F.2 Boot progress code format - Arm® Server Base Manageability Requirements 2.0
PLDM event log mechanism

nicklela commented 1 year ago

@changab, @wangsim is working on this and we are using boot progress code. Not sure if you check PLDM evet path or not...

nicklela commented 1 year ago

This is how edk2 does this:

https://github.com/nicklela/edk2-redfish-client/blob/99bc4c50e80ff25d8dfc1cd5b02cceb6d2eb3482/MdePkg/Include/Pi/PiStatusCode.h#L100-L108

https://github.com/nicklela/edk2-redfish-client/blob/99bc4c50e80ff25d8dfc1cd5b02cceb6d2eb3482/MdeModulePkg/MdeModulePkg.dec#L1470-L1480

nicklela commented 1 year ago

After discussion, we can send RFC to edk2-devel and propose to add Manageability status code to PiStatusCode.h