nicklockwood / AsyncImageView

[DEPRECATED]
http://charcoaldesign.co.uk/source/cocoa#asyncimageview
Other
906 stars 186 forks source link

UIImages are now created with a default retina scale #38

Open mikelovesrobots opened 11 years ago

mikelovesrobots commented 11 years ago

As of iOS7, all devices sold are retina, so it makes sense to transition to loading all the images with the proper scale. This makes it possible when using UIImageViews to use the more interesting view modes like top-left, bottom-right, etc.

If you merge this directly, you'll break the code of people who depended on the old behavior. You might want to make it configurable with the default being 2.0.

[edit] It's not true about all ios7 devices being retina. See comment by bastionhoyer below.

bastianh commented 11 years ago

ipad mini is not yet retina and might get delayed until 2014

mikelovesrobots commented 11 years ago

Interesting. Anyway, we found it confusing to work with UIImages from the web at scale 1 in our app. Maybe it should be configurable.

fraserscottmorrison commented 9 years ago

So how can I use this library to load a retina image from a url? The image scale should definitely be configurable now!

fantattitude commented 9 years ago

Wouldn't it be more interesting to add the ability to look for @2x and @3x images if the device is detected as not having the legacy scale ? This way nothing is broken for people relying to the old behavior.