search

nicklockwood / Expression

A cross-platform Swift library for evaluating mathematical expressions at runtime
MIT License
830 stars 51 forks source link

Add lock support to Linux #24

Closed flangel closed 5 years ago

flangel commented 5 years ago

Dear Nick,

This patch

  1. adds support for locking on the Linux platform by using NSLock instead of objc_sync_enter and objc_sync_exit
  2. Update small cross platform issue with String class. String(value) --> String(describing:value)

Please let me know if I missed anything. Hope this finds your approval.

Best Frank

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.0007%) to 99.798% when pulling 1cddbfff576352d16a1f8597e54610634faf0d7a on flangel:master into 47c3e84fc8f584272c3b84bb6d289a43dbd98eab on nicklockwood:master.

flangel commented 5 years ago

@nicklockwood Hi Nick, not sure about the coveralls report. Any idea why it fails. This might be a false negative. Best Frank

nicklockwood commented 5 years ago

@flangel looks like it might be an improvement to the Swift compiler that means a couple of the Equatable cases don't get hit. Nothing to worry about.

flangel commented 5 years ago

Ok. Thanks in advance.

flangel commented 5 years ago

@nicklockwood Hi Nick, is there anything I can do to help with the merge ?