conditionalAssignment rule

[valeriachub]

Hello developers, there are some issues with conditionalAssignment rule.

Version 0.52.6 / Swift 5.9

It reformats the following code:

let text: String
if conditionOne {
  text = "Hello World!"
  doSomeStuffHere()
} else {
   text = "Goodbye!"
}

to one with errors:

let text: String = if conditionOne {
  "Hello World!" // <---- Expression of type `String` is used
  doSomeStuffHere()
} else { // <---- Non-expression branch of `if` expression may only end with a `throw`
  "Goodbye!"
}

Could you please check?

Thank you!

[nicklockwood]

Cc @calda

[calda]

Will take a look

[calda]

Here you go: https://github.com/nicklockwood/SwiftFormat/pull/1539

[nicklockwood]

@valeriachub fixed in 0.52.7