search

nicklockwood / SwiftFormat

A command-line tool and Xcode Extension for formatting Swift code
MIT License
7.67k stars 623 forks source link

Fix issue where parseType helper didn't handle qualified types like Foo.Bar #1597

Closed calda closed 6 months ago

calda commented 7 months ago

This PR fixes an issue where the parseType helper didn't handle qualified types like Foo.Bar or Foo.Bar.Baaz.

This could cause the isStoredProperty(atIntroducerIndex:) helper to return the incorrect result for properties with a qualified type name, like in the example added as a test case.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4a072af) 95.11% compared to head (27b7a7a) 95.10%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1597 +/- ## =========================================== - Coverage 95.11% 95.10% -0.01% =========================================== Files 20 20 Lines 22112 22122 +10 =========================================== + Hits 21032 21040 +8 - Misses 1080 1082 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.