codecov[bot]
commented
8 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
ad7707b) 95.25% compared to head (c7038c9) 95.22%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #1605 +/- ## ========================================== - Coverage 95.25% 95.22% -0.03% ========================================== Files 17 17 Lines 20751 20751 ========================================== - Hits 19766 19761 -5 - Misses 985 990 +5 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Currently, the pre-built binary targeting Linux links Swift stdlib and core libraries dynamically. Unlike darwin platforms, Swift does not guarantee ABI stability on Linux, so the pre-built binary must be run with exactly the same version of Swift stdlib and core libraries that it was built with on GitHub Actions. And also the shared libraries can be installed in various locations, so users usually need to set
LD_LIBRARY_PATH.However, asking users to do the above works only for power users. Reducing the runtime dependencies makes it usable for more users.
The only downside of static-linkage is the significant binary-size (9.4M -> 57M). But IMHO a larger binary is better than the one hard to run. The most of huge binary size came from unused ICU data and Foundation, so we can expect it will be much smaller after adopting https://github.com/apple/swift-foundation and LTO integration in SwiftPM (upcoming in 5.10)