Closed calda closed 4 weeks ago
Attention: Patch coverage is 87.50000%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 95.15%. Comparing base (
f487996
) to head (de86b97
).
Files | Patch % | Lines |
---|---|---|
Sources/FormattingHelpers.swift | 87.50% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR fixes a regression introduced by #1678 where conditional compilation blocks would be sorted incorrectly (always at the bottom).
Previously the
organizeDeclarations
rule supported a partial ordering, where any declaration without a defined type would just preserve its existing relative ordering. The architecture changes to theorganizeDeclaration
rule now require a total ordering of declarations, so every declaration must have a well defined type.Since conditional compilation blocks can have multiple nested declarations with different types, we previously just used
type: nil
for these. #1678 made these a type of their own which was sorted last. Now, we instead use the type of the first declaration in the conditional compilation block. This better matches the previous behavior.Before
After