nicklockwood / iRate

[DEPRECATED]
http://charcoaldesign.co.uk/source/cocoa#irate
Other
4.1k stars 733 forks source link

Event count triggering rate window prematurely #178

Closed ghost closed 8 years ago

ghost commented 10 years ago

@dayjer was right here in my opinion: https://github.com/nicklockwood/iRate/issues/56

Here is an example where iRate does not work as it should: [iRate sharedInstance].promptAtLaunch = NO; [iRate sharedInstance].usesUntilPrompt = 2; [iRate sharedInstance].eventsUntilPrompt = 2;

Calling [[iRate sharedInstance] logEvent:NO] will display the rate window if either the uses condition or the events condition is met, regardless of whether both conditions are met or not.

While I like iRate more than Appirater, I find Appirater more accurate to the parameters set.

I think that all conditions that are set should be met in order to display the rate window.

If an app is interested only in significant events, the usesUntilPrompt will be automatically set at 10 and its value will be considered by the code. That means that after 10 uses even one event will cause the rate window to show.