nicklockwood / iRate

[DEPRECATED]
http://charcoaldesign.co.uk/source/cocoa#irate
Other
4.1k stars 734 forks source link

Logic errors in usesUntilPrompt and eventsUntilPrompt? #287

Open Permusoft opened 7 years ago

Permusoft commented 7 years ago

https://github.com/nicklockwood/iRate/blob/master/iRate/iRate.m#L484

If either usesUntilPrompt or eventsUntilPrompt is zero then both values are effectively ignored. It's reasonable for developers to set one or the other to zero to indicate no interest in value.

Perhaps give eventsUntilPrompt its own else if, in keeping with the rest of shouldPromptForRating?