search

nicklockwood / iRate

[DEPRECATED]
http://charcoaldesign.co.uk/source/cocoa#irate
Other
4.1k stars 734 forks source link

useSKStoreReviewControllerIfAvailable is ignored #296

Open dtdw opened 7 years ago

dtdw commented 7 years ago

useSKStoreReviewControllerIfAvailable is set to YES by default but not tested in code. The call should be like

if (!manual && [SKStoreReviewController class] && self. useSKStoreReviewControllerIfAvailable) { ... }

in - (void)promptForRating:(BOOL)manual

nicklockwood commented 7 years ago

Yes, this is a bug. It sounds like not using SKStoreReviewControllerIfAvailable may be prohibited on iOS 11 anyway, so I may just remove the option.

mTuran commented 6 years ago

Bug confirmed. useSKStoreReviewControllerIfAvailable is ignored.

nicklockwood commented 6 years ago

AFAIK, Apple is now rejecting apps that don't use SKStoreReviewControllerIfAvailable, so this seems like a low priority to fix.

mTuran commented 6 years ago

Yes, I heard this before but I submitted a lot of apps that does not use SKStoreReviewControllerIfAvailable and they approved without issues.