SKStoreReviewController is not used in manual prompt request

djachenko commented 7 years ago

According to code, iOS 10.3+ rate popup can only be requested if both SKStoreReviewController is available and manual flag is set to NO:

if (!manual && [SKStoreReviewController class])
{
    [self remindLater];
    [SKStoreReviewController requestReview];
}

But in - promptForRating method this flag is unconditionally set to YES:

- (void)promptForRating
{
    [self promptForRating: YES];
}

At the same time - promptForRating: is unavailable from public interface of iRate. The result is that SKStoreReviewController's popup can never be shown in explicit review request from code. Is this the intentional design or an issue?

nicklockwood commented 7 years ago

It's intentional. Apple says that you should never show SKStoreReviewController using a user-facing button because it's not guaranteed to appear.

djachenko commented 7 years ago

Oh. I've overlooked some parts of interface designed for manual review requesting. I'm sorry for disturbance.

nicklockwood / iRate

SKStoreReviewController is not used in manual prompt request #298