search

nicklockwood / iRate

[DEPRECATED]
http://charcoaldesign.co.uk/source/cocoa#irate
Other
4.1k stars 734 forks source link

ratedThisVersion not set if using SKStoreReviewController? #307

Open garrettmoon opened 7 years ago

garrettmoon commented 7 years ago

It appears as if ratedThisVersion is not set when requesting reviews with SKStoreReviewController? If I'm reading things correctly, the rate method is never called.

This would mean that once the other thresholds are crossed for requesting a rating, we will continually prompt for a rating if using SKStoreReviewController.

Or I'm misunderstanding something :)

nicklockwood commented 7 years ago

SKStoreReviewController implements its own throttling, so it won't keep prompting aftet the user rates the app.

garrettmoon commented 7 years ago

I assume this will also pretty quickly use up the 3 requests per year restriction on SKStoreReviewController.

nicklockwood commented 7 years ago

I'm not sure how that's measured. I'm assuming that a) it won't prompt the user to rate a version they've already rated, and b) a request to rate that doesn't display anything won't count against the 3 prompt limit.

AFAIK, there's no way to detect whether the user actually rated the app, which is why I don't set the ratedThisVersion flag.

garrettmoon commented 6 years ago

Feel free to close this out, I mainly wanted to make sure it was reported if it was unknown.

One other point, because the ratedThisVersion flag is not set, the promptForNewVersionIfUserRated option does not work?