nicklockwood / iVersion

[DEPRECATED]
http://www.charcoaldesign.co.uk/source/cocoa#iversion
Other
1.95k stars 292 forks source link

clean up 'Undeclared selector' warnings #56

Closed mpillsbury closed 10 years ago

mpillsbury commented 10 years ago

In Xcode 5, the LLVM Undeclared Selector warning defaults to Yes. This causes several warnings to appear in iVersion (mostly in deprecated code paths, but @selector(viewController) seems to be current code).

You can switch off the warnings, but if you're using CocoaPods, every pod install will reset them back to the default Yes setting.

This StackOverflow post has a few suggestions about suppressing or preventing the warnings; I can submit a pull request, but I'm not sure which way you'd want to go with this.

tplessis commented 10 years ago

And when you try to submit your app to the AppStore, you get this message : "This app references non--public selectors in Payload : viewController".

942v commented 10 years ago

Yes, I have the same issue with the viewController reference.

mpillsbury commented 10 years ago

Oh, is that where that warning came from? I saw it last time I submitted to the App Store, but searching through instances of viewController in my codebase was too labor-intensive to track down. Thanks for pointing that out, @tplessis.

s5 commented 10 years ago

I'm also having the same problem with validation warnings from iVersion when submitting to the App Store. Looks to be solved in the latest 1.11 beta but Cocoapods is at 1.10.6, and it was easier to comment out that one line of code in iVersion.m than change my entire workflow. But I do hope this fix ships soon!

nicklockwood commented 10 years ago

You don't need to change your workflow or modify the library, you can use the current beta version by putting this in your pod file:

pod 'iVersion', :git => 'https://github.com/nicklockwood/iVersion.git'

s5 commented 10 years ago

Good call, thanks!

On Mon, Feb 24, 2014 at 1:15 PM, Nick Lockwood notifications@github.com wrote:

You don't need to change your workflow or modify the library, you can use the current beta version by putting this in your pod file:

pod 'iVersion', :git => 'https://github.com/nicklockwood/iVersion.git'

Reply to this email directly or view it on GitHub: https://github.com/nicklockwood/iVersion/issues/56#issuecomment-35938918

stevemoser commented 10 years ago

+1 I was just bitten by this when submitting to the AppStore. "This app references non--public selectors in Payload : viewController" Is there an ETA of when this is leaving beta?

gonghao commented 10 years ago

+1 This issue shown when I use the version 1.10.6 and compile my App in Xcode 5.1.1, and I have to remove these lines in iVersion.m:

        if ([appDelegate respondsToSelector:@selector(viewController)])
        {
            rootViewController = [appDelegate valueForKey:@"viewController"];
        }

So this let the warning gone, and I could submit my App.

nicklockwood commented 10 years ago

Fixed in 1.11