search

nicklockwood / layout

A declarative UI framework for iOS
MIT License
2.23k stars 97 forks source link

Swift 4.2 / XCode 10 compatiblity #130

Closed Kaspik closed 6 years ago

Kaspik commented 6 years ago

Hey team!

Currently Layout is the only pod inside our huge app that is not working on XCode 10 beta. I'm not opening this as issue that should be addressed ASAP to release, but to start conversation and migration to this version at least on some branch or master.

Here are things that are not working: AnyExpression.swift

Let me know what you are planning about these updates, if we should create branch, or just PRs, or if you are going to take care of that. Thank you!

nicklockwood commented 6 years ago

@Kaspik I’ve already completed most of the fixes. Should have a 4.2-compatible release ready shortly.

nicklockwood commented 6 years ago

@Kaspik OK, I've pushed a version that supports 4.1.5 to the develop branch (4.1.5 is what Xcode 10 beta uses when you select "Swift 4" as the language version, and it's probably what you're using based on the errors you reported).

Full Swift 4.2 support will take a little bit longer as Apple has renamed a load of UIKit methods and constants.

Kaspik commented 6 years ago

Ohh perfect, yeah, I don’t need 4.2 probably if 4.1.5 is what XCode 10 uses. I’ll try the branch. Thank you!

Kaspik commented 6 years ago

@nicklockwood Perfect, develop works a so the app, thank you!

nicklockwood commented 6 years ago

Fixed in version 0.6.25