nickmckay / GeoChronR

Development repository for GeoChronR
http://nickmckay.github.io/GeoChronR/
MIT License
32 stars 3 forks source link

proper convert of plotChronEns to BC/AD #58

Open JanPetrik1 opened 2 years ago

JanPetrik1 commented 2 years ago

Dear Nick, I really like this library. Recently I have an issue with converting of oxcal age-dept model to BC/AD. It works with convertBP2AD model$chronData[[1]]$model[[1]]$ensembleTable[[1]]$ageEnsemble, but violin plot remains in the original position.

nickmckay commented 2 years ago

I'm glad you're enjoying the package. Are you getting this error when you run plotChron(), or plotChronEnsemble() or something else? I'll look into it.

JanPetrik1 commented 2 years ago

Thank you for the quick reply. It is plotChronEnsemble().

po 6. 12. 2021 v 16:36 odesílatel Nick McKay @.***> napsal:

I'm glad you're enjoying the package. Are you getting this error when you run plotChron(), or plotChronEnsemble() or something else? I'll look into it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nickmckay/GeoChronR/issues/58#issuecomment-986890322, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUZ2AWY2K4BKJPVIUW72I3TUPTJ6HANCNFSM5JM6HGEA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

JanPetrik1 commented 2 years ago

It could be also improvement, if it will recognise AD and BCE instead putting negative values of AD. It is not a big problem, because user can change label, but change trogh convert function could be more convenient. It could be possibly solved by adding of third option: convert to BC/BCE :)