search

nickmckay / LiPD-utilities

Input/output and manipulation utilities for LiPD files in Matlab, R and Python
http://nickmckay.github.io/LiPD-utilities/
GNU General Public License v2.0
29 stars 9 forks source link

Can't have python files in the R/R folder #18

Closed gavinsimpson closed 7 years ago

gavinsimpson commented 7 years ago

Convention (i.e. R CMD check) is that only R code should be in the R folder of a package. Currently there is a bam.py bagit.py file that is required by the package. I suggest this is moved to R-PKG-ROOT/exec/bam.py R-PKG-ROOT/exec/bagit.py and the R code calling it adjusted so that it knows about the new location.

chrismheiser commented 7 years ago

Are you referencing the bagit.py by chance? I'm not aware of any bam.py files.

gavinsimpson commented 7 years ago

Sorry @chrismheiser, I was reading something else and got the files confused. Yes, I mean the bagit.py file. I'll edit my original report.