search

nickmckay / LiPD-utilities

Input/output and manipulation utilities for LiPD files in Matlab, R and Python
http://nickmckay.github.io/LiPD-utilities/
GNU General Public License v2.0
28 stars 9 forks source link

R: warn user about writing ageEnsemble data in paleoData #34

Closed nickmckay closed 6 years ago

nickmckay commented 6 years ago

writeLipd() should warn people about writing ageEnsembles that have been mapped into paleoData. This is a common procedure in GeoChronR, and thus will come up, however it can greatly increase the size of the LiPD file, and is easily and quickly replicated upon loading with geoChronR::mapAgeEnsembleToPaleoData() .

Perhaps a warning, and then a yes/no about deleting the ageEnsemble from the paleoData?

chrismheiser commented 6 years ago

@nickmckay Should this be a "yes" or "no" parameter to writeLipd or just prompt the user on a file-by-file basis? I'm sure it'll get annoying to answer a lot of prompts if you write a bunch of files at once, but I'm also not sure that there will be a ton of files with ensemble data in Paleo, in which case file-by-file prompts may not be so bad.

Thoughts?

nickmckay commented 6 years ago

Hmm,

How about the default is case by case, but there's an "ignore.warnings" option that's set to FALSE by default in writeLipd()?

On Thu, Mar 8, 2018 at 12:38 PM, Christopher Heiser < notifications@github.com> wrote:

@nickmckay https://github.com/nickmckay Should this be a "yes" or "no" parameter to writeLipd or just prompt the user on a file-by-file basis? I'm sure it'll get annoying to answer a lot of prompts if you write a bunch of files at once, but I'm also not sure that there will be a ton of files with ensemble data in Paleo, in which case file-by-file prompts may not be so bad.

Thoughts?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nickmckay/LiPD-utilities/issues/34#issuecomment-371599607, or mute the thread https://github.com/notifications/unsubscribe-auth/AK73Z2BPx0gJ2KQ-dTbQ3OWuMZLvZvOOks5tcYi6gaJpZM4SPpTh .

chrismheiser commented 6 years ago

And if ignore.warnings were set to TRUE, then don't bother to check for ensemble data in paleo? Or remove the ensemble data from paleo and just don't write about it?

nickmckay commented 6 years ago

Write it without a warning.

On Thu, Mar 8, 2018 at 12:48 PM, Christopher Heiser < notifications@github.com> wrote:

And if ignore.warnings were set to TRUE, then don't bother to check for ensemble data in paleo? Or remove the ensemble data from paleo and just don't write about it?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nickmckay/LiPD-utilities/issues/34#issuecomment-371602725, or mute the thread https://github.com/notifications/unsubscribe-auth/AK73Z6ZmQFHNrwmu_-rfw7kjTaxnXucHks5tcYsYgaJpZM4SPpTh .