search

nickmckay / LiPD-utilities

Input/output and manipulation utilities for LiPD files in Matlab, R and Python
http://nickmckay.github.io/LiPD-utilities/
GNU General Public License v2.0
29 stars 9 forks source link

Fixes R CMD check note re global variable paleoData_TSid #63

Closed gavinsimpson closed 4 years ago

gavinsimpson commented 4 years ago

This PR fixes the note under R CMD check about undeclared global variable paleoData_TSid using the rlang::.data trick.

This fix requires the addition of the rlang package as an Import in DESCRIPTION.

Note that R CMD check will still error out unless #62 is applied to add missing Imports to DESCRIPTION, but I made this PR standalone to encapsulate only the fix for this particular global variable issue.

Note that R CMD check still complains about missing global variable d in the validate_parameters() function, but I believe this is an actual bug in the function which needs a proper fix (looks like a copy-paste type issue)

nickmckay commented 4 years ago

Merged, and fixed validate_parameters(). Thanks for this!