search

nickmcmillan / react-physics-dragger

A simple, no-frills horiztonal dragger/slider with physics
202 stars 10 forks source link

Ts setup #12

Closed nickmcmillan closed 5 years ago

nickmcmillan commented 5 years ago

Continues https://github.com/nickmcmillan/react-physics-dragger/pull/9

trblackw commented 5 years ago

@vaibhavhrt @nickmcmillan Looks like #12 is causing some issues. Travis doesn't seem very happy with it.

nickmcmillan commented 5 years ago

@trblackw that's because Travis is running lintJs - which is no longer used. In my last commit I simply made lintJs an alias for yarn run test. It's passing now.

trblackw commented 5 years ago

@nickmcmillan Gotcha, looks good to me then

vaibhavhrt commented 5 years ago

Looks good to me. We can decide on code style guide in some other PR and setup linting there.

trblackw commented 5 years ago

Agreed

On Thu, Jun 27, 2019 at 6:54 AM Vaibhav Vishal notifications@github.com wrote:

Looks good to me. We can decide on code style guide in some other PR and setup linting there.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/nickmcmillan/react-physics-dragger/pull/12?email_source=notifications&email_token=AIVCT23M7FLR4OX7BK6XL5TP4SL4TA5CNFSM4H26OAE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYWX3XI#issuecomment-506297821, or mute the thread https://github.com/notifications/unsubscribe-auth/AIVCT24USRMXC67F4GMC333P4SL4TANCNFSM4H26OAEQ .

nickmcmillan commented 5 years ago

Merged! Great work @trblackw & @vaibhavhrt. I'll release this on npm as 1.1.1

nickmcmillan commented 5 years ago

Closes #5

vaibhavhrt commented 5 years ago

Nice, you guyz can open an issue for discussing style guide and linter to use. I am super busy these days, I will start working on writing tests first week of next month. By that time at least we will have a linter with style rules.

trblackw commented 5 years ago

I’m pretty busy as well, #agencylife, is there anything else that’s needed to be done other than creating a style guide?

On Thu, Jun 27, 2019 at 7:02 AM Vaibhav Vishal notifications@github.com wrote:

Nice, you guyz can open an issue for discussing style guide and linter to use. I am super busy these days, I will start working on writing tests first week of next month. By that time at least we will have a linter with style rules.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/nickmcmillan/react-physics-dragger/pull/12?email_source=notifications&email_token=AIVCT26GF56BPTV5XQNVTUDP4SM5TA5CNFSM4H26OAE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYWYR2Q#issuecomment-506300650, or mute the thread https://github.com/notifications/unsubscribe-auth/AIVCT26TKMW2HPZKVWN7SZLP4SM5TANCNFSM4H26OAEQ .

vaibhavhrt commented 5 years ago

I don't think so. Someone has asked for pagination feature but I know what the consensus is on whether to add it or not.