search

nickmerwin / node-coveralls

lcov posting to coveralls.io
Other
1.07k stars 258 forks source link

error from convertLcovToCoveralls with nyc version 14 #219

Open zhaoqin-github opened 5 years ago

zhaoqin-github commented 5 years ago

My Travis CI job fails with the latest nyc version 14.0.0

> waf@1.0.0 coveralls /home/travis/build/F5Networks/f5-adcaas-openstack/app/waf
> lb-nyc report --reporter=text-lcov | coveralls ../../
[error] "2019-04-22T02:23:19.206Z"  'error from lcovParse: ' 'Failed to parse string'
[error] "2019-04-22T02:23:19.208Z"  'input: ' ''
[error] "2019-04-22T02:23:19.208Z"  'error from convertLcovToCoveralls'
/home/travis/build/F5Networks/f5-adcaas-openstack/app/waf/node_modules/coveralls/bin/coveralls.js:18
        throw err;
        ^
Failed to parse string

After I downgrade nyc version to 13.3.0, coveralls command works perfectly.

stevenvachon commented 5 years ago

I think this is a duplicate of #207

zhaoqin-github commented 5 years ago

@stevenvachon My node version is 8.9.4. I guess the lcov report format made by nyc v14 might have some small changes.

You may see the error at the end of my Travis log.

https://travis-ci.org/F5Networks/f5-adcaas-openstack/builds/522088170

zhaoqin-github commented 5 years ago

@stevenvachon I save the nyc output to files. Nyc.13.txt is made by nyc v13.3.0, which can be processed by coveralls. Nyc.14.txt is made by nyc v14.0.0, which can not be processed by coveralls. If you or anybody can help to figure out the root cause, that will be great.

nyc.13.txt

nyc.14.txt

XhmikosR commented 5 years ago

Works fine in the PR I have https://github.com/nickmerwin/node-coveralls/pull/235