search

nicknamenic / pe

0 stars 0 forks source link

incomplete class diagram #10

Open nicknamenic opened 5 months ago

nicknamenic commented 5 months ago

image.png

attributes of the travel classes are not shown

nus-pe-bot commented 5 months ago

Team's Response

Thanks for pointing this out. We will include it in future versions, we missed it out.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: Actually, considering that the attributes of all the classes with the missing attributes are not shown anywhere else in the DG, as another developer reading the DG, I would not be able to recreate any of these classes at all. Adding to that, the classes are the literal backbone of the program, being something that all the other programs are dependent on (find, tag, check, etc.). The only clue for the attributes would be in the commands themselves and their required and optional inputs, but these do not include the private methods stored within each one.

image.png

In the above and below, it is ok as the attributes are consistently missing.

image.png