nicknsy / jellyscrub

Smooth mouse-over video scrubbing previews for Jellyfin.
MIT License
670 stars 27 forks source link

Add Process Priority setting #11

Closed Froghut closed 2 years ago

Froghut commented 2 years ago

Add a setting to the plugin configuration to change the Process Priority of the ffmpeg .bif generation process

nicknsy commented 2 years ago

Thanks for the pull request. Could you explain the use of setting process priority? I don't really know what it does so in what cases would it be useful to set and change?

Froghut commented 2 years ago

So if 100% of cpu power is used the process priority will determine how much of the cpu power the processes will get. So if you set priority to idle the process might get nothing, and if you set it to High it will get most of the requested cpu power. On my server for example I'm sometimes close to utilizing my CPU 100% and I don't care that much if .bif generation gets slower during those times, I'd rather my other process get priority.

satmandu commented 2 years ago

Exactly this. Right now bif generation on my server is at normal priority. But I should be able to set it to lowest priority, as there are other things (like playing videos) that should take higher priority.

nicknsy commented 2 years ago

I've never really done git merges/pulls before so I'm not sure if I can do this myself, but could you change this to be a pull request to the beta branch?

Froghut commented 2 years ago

Haven't worked with git/github that much before myself, but I think I managed to change it to the beta branch :)