search

nicknsy / jellyscrub

Smooth mouse-over video scrubbing previews for Jellyfin.
MIT License
670 stars 27 forks source link

Show timestamp instead of percentage of scrobble images are not created yet #31

Closed Pfuenzle closed 2 years ago

Pfuenzle commented 2 years ago

When the scrobble images have not been generated and a user hovers over the timeline, instead of the time the percentage of the progress is shown.

This is IMO not really helpful to the user, Is this intended or would you be willing to change it? Thanks a lot :)

grafik

nicknsy commented 2 years ago

Is this a TV show? If so, it may be related to #28. It's supposed to keep default functionality if there are no trickplay files, and I'm pretty sure it worked before on movies but I'm not 100%.

Fallenbagel commented 2 years ago

I can confirm that on my end, files that have no trickplay generated does indeed have the default functionality intact on both tv shows and movies and that percentage is shown on files that have been generated but the functions (GetBif/GetManifest) not called

nicknsy commented 2 years ago

Fixed by https://github.com/nicknsy/jellyscrub/commit/f69f784889063ce5b3ea7d1e5ce674e8af32ed23