nicknsy / jellyscrub

Smooth mouse-over video scrubbing previews for Jellyfin.
MIT License
670 stars 27 forks source link

[Question] How do I activate it on Jellyfin Windows version? #51

Closed KimPig closed 1 year ago

KimPig commented 1 year ago

I installed Jellyfin in the Windows installer version. After installing this plugin in the repository, I created the BIF file in the media folder, but it does not work. Do I need to manually put the script in the jellyfin-web folder to work? Also, is the way I put the script correct?

image

I'm sorry for the rudimentary question.

nicknsy commented 1 year ago

Looks like the script line is in the correct location

KimPig commented 1 year ago

Here's part of log

[2022-11-21 23:33:15.453 +09:00] [INF] [1] Nick.Plugin.Jellyscrub.JellyscrubPlugin: Found client script injected in "C:\Program Files\Jellyfin\Server\jellyfin-web\index.html"
[2022-11-21 23:33:15.456 +09:00] [INF] [1] Emby.Server.Implementations.Plugins.PluginManager: Loaded plugin: "Jellyscrub" "1.0.0.6"

I craeted BIF file thorugh scheduled task and there is BIF file in media folder. Also, I deleted website cache and cookies.

I'm using Jellyfin-web customized by Introskipper. Could this be a problem?

nicknsy commented 1 year ago

Hmm not sure if using the intro skipper web at the same time would cause issues, but I wouldn't think so.

Can you open developer tools in your browser, go to "Console" and refresh the jellyfin page and see if there are any errors on load. Also if you click on a video it should make mention of whether a BIF file was found in the console. Could you screenshot and upload an image of what the console says?

Also, if you want to manually make sure the trickplay script endpoint works try going to http://{your jellyfin}/Trickplay/ClientScript and making sure it returns the script.

Also, did you manually put the line in the index.html or did the plugin inject it? If you manually put it and have a custom base path set in jellyfin that could cause issues.

KimPig commented 1 year ago

Maybe I found a reason. The first time the BIF file was created, the BIF was created in "TVShow" folder. But when I asked to create the BIF file again, the BIF was created in the "TVShow/tricplay" folder. I don't know what the problem was, but it works now. But Jellyfin recognizes trickplay as a season. image

Should I turn on this option? Or should I turn it off? image

Ps. Originally, does it use ffmpeg to generate BIF? A day later, only 15 percent of all media was created.

nicknsy commented 1 year ago

Yes, it uses ffmpeg to extract frames from the videos. It can take quite a while to finish depending on the cpu you have in the system.

As for whether or not to save to the media folder, it's up to you. I think saving to the media folder makes them easier to manage/move in the future. However, once you turn it on I wouldn't turn it off as it would require regenerating all BIF files in a new location.

KimPig commented 1 year ago

When saved to the media folder, Jellyfin seems to recognize the trickplay folder as a season. Can't I solve this?

nicknsy commented 1 year ago

What is your folder structure for television? I've heard if you don't create subfolders for each season it will do this. Is your folder structure like this?

I haven't personally experienced this but this was said to be the issue on #21. Will be looking into adding an ignore file, but if you don't want to change your folder structure you could manually add a file called ".ignore" to the trickplay folder for the time being.

KimPig commented 1 year ago

Oh, I got it. However, adding .ignore files one by one is too much work. I hope the file will be automatically created soon.