search

nicknsy / jellyscrub

Smooth mouse-over video scrubbing previews for Jellyfin.
MIT License
668 stars 27 forks source link

Srcub preview does not work with jellyfin-tizen #67

Open malefice opened 1 year ago

malefice commented 1 year ago

Hey @nicknsy! First of all, thanks for your efforts with this plugin! Hopefully my feedback here can help improve the plugin.

Anyway, I am aware that this only works with web players due to the javascript injection mechanism. Tested this on android mobile, and it works perfectly when using web player, but for some reason, this does not work on jellyfin-tizen even though the app is just a wrapper around a jellyfin web frontend.

I have tried including the script tags in the web dist files prior to building for tizen and even including /Trickplay/ClientScript inside the dist files as well. On a sidenote, I used similar methods with intro-skipper which relies on websockets, and it works on android mobile and tizen.

Wondering if you have any ideas as to what can cause it not to work and if you have suggestions I can try to test.

NeroPcStation commented 1 year ago

What version of tizen do you have ?

nicknsy commented 1 year ago

I've never used the tizen jellyfin so nothing immediately comes to mind. If you're manually building it maybe you'd be able to debug the app within the IDE to look for any errors.

You could also try using the trickplay.js code from @NeroPcStation 's latest pull request--maybe tizen also doesn't support some of the newer JS syntax.

malefice commented 1 year ago

What version of tizen do you have ?

Not sure which tizen you meant, so here are all the versions that could be applicable: Tizen Browser Version: 4.2.11030 Tizen Browser User Agent: Mozilla/5.0 (SMART-TV; Linux; Tizen 6.0) AppleWebKit/537.36 (KHTML, like Gecko) SamsungBrowser/4.0 Chrome/76.0.3809.146 TV Safari/537.36 Tizen Version: guess it is 6.0 based on user agent Jellyfin-Tizen version: No versioning yet but at commit 8db7ccd Dec 5, 2022

You could also try using the trickplay.js code from @NeroPcStation 's latest pull request--maybe tizen also doesn't support some of the newer JS syntax.

Tried it, but did not work unfortunately. I do not have time yet to sit down and really debug with the IDE though.

X8Haz commented 7 months ago

@malefice, did it work with you?