search

nickoneill / PermissionScope

Intelligent iOS permissions UI and unified API
MIT License
4.85k stars 507 forks source link

Fix infinite loop when waiting for motion status #161

Open fotiDim opened 8 years ago

fotiDim commented 8 years ago

This PR fixes a very important issue. I had an infinite loop when I was waiting for motion status. I noticed this accidentally in my app's last version. This used to work and I am not sure what broke it (iOS 9 or some other change in the library) but it should work fine after merging this.

nickoneill commented 8 years ago

Hey @Navideck-fotis, thanks for reporting this. Does this occur whenever you request motion or just in some unusual cases?

fotiDim commented 8 years ago

It happens every time. I guess nobody else tested motion or maybe they overlooked it.

As an additional safety measure maybe we could add a timeout to the waiting loop.

fotiDim commented 8 years ago

@nickoneill any updates on this?

nickoneill commented 8 years ago

I have a day scheduled for open source work early next week, I'll make all these changes and a new release then.

fotiDim commented 7 years ago

Ping