search

nickoneill / PermissionScope

Intelligent iOS permissions UI and unified API
MIT License
4.85k stars 507 forks source link

Allow more characters and remove the need for hard-coded line breaks in labels #164

Open VFUC opened 8 years ago

VFUC commented 8 years ago

I localised some strings to German in another PR (#162) and got the (valid) response that the increasing character count would not lay out well. Considering the possibility of other languages having a similar affection for long words, I think it's not a bad idea to make the labels more flexible. I put the proposed minimumScaleFactor to 0.75, which in my opinion still qualifies as legible. In the example of the "bodyLabel" it allows for ~100 additional characters. This also removes the need to add line breaks into the middle of the strings.

nickoneill commented 8 years ago

Thanks @VFUC! I'll check this out.

bre7 commented 8 years ago

Note: Don't forget to update Keys (string files)