search

nickoneill / PermissionScope

Intelligent iOS permissions UI and unified API
MIT License
4.85k stars 507 forks source link

Support for transition animations #171

Open akofman opened 8 years ago

akofman commented 8 years ago

Hello,

Thanks for your awesome work ! It Would be nice to add some animation effects and the availability to configure it from an other custom properties. What do you think ?

nickoneill commented 8 years ago

Hi @akofman - what were you hoping to animate and in what style?

akofman commented 8 years ago

I mean, the dialog is sliding from top to bottom by default when appearing. I'd like to change this behaviour, like adding some bounce effect for instance, or just disable it.

nickoneill commented 8 years ago

Great, so this is going to be tightly coupled with the work in #148 to make the presentation a standard view controller. After that's done, you should be able to define your own transition animation delegate and do whatever animation you want.

akofman commented 8 years ago

It sounds awesome :+1: Thanks for your reply. And by the way I'm implementing a Cordova plugin that wrap your work. It's in progress ... just to let you know : https://github.com/akofman/cordova-plugin-permissionScope

nickoneill commented 8 years ago

That's great, thanks @akofman! I'll update this issue when we tackle #148