search

nickoneill / PermissionScope

Intelligent iOS permissions UI and unified API
MIT License
4.85k stars 507 forks source link

Swift3 UserNotifications support #191

Open robbiet480 opened 7 years ago

robbiet480 commented 7 years ago

See also #192 for a Swift 2.x version of this code.

Closes #190.

robbiet480 commented 7 years ago

@nickoneill The example app is somewhat broken on iOS 10 simulator it seems. It looks like this:

screen shot 2016-09-08 at 6 00 29 pm
nickoneill commented 7 years ago

Hey @robbiet480, that happened occasionally in the iOS 9 simulator as well. I'll check if it's any more reliably broken in the new sim.

nickoneill commented 7 years ago

Hey there, any chance you can rebase this against master? Freshly swift3.

robbiet480 commented 7 years ago

@nickoneill done!

tartakovsky commented 7 years ago

@nickoneill Hey Nick. We wait for this one to be merged :) Can we do something to speedup the process?

nickoneill commented 7 years ago

I'll check this out in the next few days @etartakovsky

4np commented 7 years ago

The code in the pull requests still uses some deprecated categories:

pod 'PermissionScope', :git => 'https://github.com/robbiet480/PermissionScope.git', :branch => 'swift3-ios10-usernotifications'
screen shot 2017-01-10 at 11 43 28
ogezue commented 7 years ago

Please merge this - for warning free XCode projects :)