search

nickoneill / PermissionScope

Intelligent iOS permissions UI and unified API
MIT License
4.85k stars 507 forks source link

Factored permissions out into subspecs #216

Open timothycosta opened 7 years ago

timothycosta commented 7 years ago

I've factored out all of the individual permissions into subspecs. However, the subspecs just add swift files into the core framework. They don't result in individual frameworks or use preprocessor macros.

Everything seems to be working except for bluetooth, which relies on a while loop on line 486 of PermissionScope.swift. I've commented out the loop for the moment as I don't quite understand how it works. It might be a very simple fix.

There are a couple of places where I've resorted to responds(to:) where I wasn't able to abstract out the current logic. It's not pretty, but I don't know a better way to get around the issue without re-architecting everything in order to pull out status and request into individual classes. That seems like it would be a good idea long term, and would probably completely sidestep the bluetooth issue.

nickoneill commented 7 years ago

Wow @timothycosta, thank you, this looks like quite a bit of work. I'll review and get back to you on your questions.

timothycosta commented 7 years ago

@nickoneill Did you ever get a chance to look at this? If you have suggestions for how I can get bluetooth working again I'd be happy to take another stab at it.

gdetari commented 7 years ago

@nickoneill any update on this? This change would be very useful.

nickoneill commented 7 years ago

No, sorry. I'm busy right now and don't have time to work on this project.