search

nickpack / ansible-role-android-sdk

Install Android SDK tools and packages, headless, with ansible.
Other
40 stars 32 forks source link

Supports versions of Ubuntu greater than 14.04 #8

Closed conorsch closed 8 years ago

conorsch commented 8 years ago

The task checking for i386 foreign architectures and registering the result should not be skipped, otherwise the subsequent conditional checks will fail on an undefined variable.

Let's update the conditional logic to use '>=' rather than '==' when comparing Ubuntu versions. Tested on Ubuntu 16.04 and seems to work OK.

nickpack commented 8 years ago

@conorsch Thanks for the PR - I'll test this on 16.04 myself later on and merge (I've not done any Android dev work for a little while now, so haven't been keeping this up to date)

conorsch commented 8 years ago

I've not done any Android dev work for a little while now, so haven't been keeping this up to date

Figured! I appreciate your publishing the role, since I recently needed to bootstrap the SDK and this role saved me a lot of time. There were a few other items I needed to configure on my Linux box to get the SDK tools working, such as udev configurations. Let me know if you're interested in further PRs here, otherwise I'll keep my changes local.

nickpack commented 8 years ago

@conorsch More PR's would be appreciated, I'm just merging this one.